Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added revokeAccessTokenBySecret() #858

Merged
merged 1 commit into from Sep 28, 2023
Merged

feat: added revokeAccessTokenBySecret() #858

merged 1 commit into from Sep 28, 2023

Conversation

WaaaghNL
Copy link
Contributor

@WaaaghNL WaaaghNL commented Sep 26, 2023

Description
After losing some tokens while i developed my app and i didnt want to remove all of the tokens i changed the revokeAccessToken to support removeing them by the secret that you can get with the AccessTokens() function.

superseded: #838

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the enhancement New feature or request label Sep 26, 2023
@datamweb datamweb changed the title Added revokeAccessTokenBySecret feat: added revokeAccessTokenBySecret() Sep 26, 2023
@kenjis
Copy link
Member

kenjis commented Sep 27, 2023

@WaaaghNL It's a little late for that, but why do you need to use secret instead of id?

@WaaaghNL
Copy link
Contributor Author

@WaaaghNL It's a little late for that, but why do you need to use secret instead of id?

I used the secret to keep it inline with the function revokeAccessToken($rawToken) where you insert the raw token.

@kenjis kenjis merged commit 7d6c685 into codeigniter4:develop Sep 28, 2023
32 of 34 checks passed
@kenjis
Copy link
Member

kenjis commented Sep 28, 2023

@WaaaghNL Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants