feat(journal-crud): Basic Journal CRUD #57
Conversation
| required: false, | ||
| }, | ||
|
|
||
| policies: { |
There was a problem hiding this comment.
Hey, @d-e-v-esh we had also planned to have a policyType field right?
There was a problem hiding this comment.
Shall I rename policies to polityType?
d-e-v-esh
force-pushed
the
journal-crud-foundation
branch
from
b79812c
to
de00a34
Compare
There was a problem hiding this comment.
Shall I rename
policiestopolicyType?
@d-e-v-esh Not really. policyType would be a property of policies
The policies object will have the following properties 👇🏻
policies {
title,
firstYear,
lastYear,
policyType
}Out of which, only lastYear property can be named as required:false and rest as required: true
Also I noticed that you discarded the lastYear property from policies whereas I intended to say that we can leave as it is, without the required: true property. Please revert this change as well.
Lmk in-case of any queries.
This commit contains the following: - Updated Journal model and typeDefs - getJournalByISSN Query - deleteJournal Mutation - updateJournal Mutation
|
There are actually more fields that are needed to be added under policies {
isDataAvailabilityStatementPublished: Boolean;
isDataShared: Boolean;
isDataPeerReviewed: Boolean;
enforced: Boolean;
enforcementEvidence: String;
}After we merge user authentication into the main |
d-e-v-esh
force-pushed
the
journal-crud-foundation
branch
from
de00a34
to
a378e92
Compare
|
I updated it. Let me know if there are any other changes. |
#54
This PR builds on the
journalResolverand adds more functionalities. Now we can do basic CRUD operations with the journal entity. More will be added on top of it in forthcoming PRs.Changes
modelandtypeDefsgetJournalByISSNQuerydeleteJournalMutationupdateJournalMutationFlags
createdAt,updatedAtandcreatedBydo not auto-populate yet. This will be added in future PRs.