Check if tkellem is running first on tkellem start #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure tkellem isn't already running when the user types tkellem start. If it is running already, print out a relevent message and exit instead of daemonizing another instance. Fixes codekitchen#31
|
thanks for this. just one stylistic comment. |
| @@ -137,6 +138,14 @@ def status(print = true) | |||
| pid.to_i > 0 ? pid.to_i : nil | |||
| end | |||
|
|
|||
| def running? | |||
There was a problem hiding this comment.
the convention in ruby is for question mark methods to return a boolean value. this method would be better named abort_if_running! or something of that nature.
There was a problem hiding this comment.
You're absolutely right. I had it returning a boolean, but changed it to just exit and forgot to rename the method. Thanks for pointing this out :)
Follow ruby naming convention. This method originally returned a boolean, but I changed what the method did and forgot to rename the method appropriately.
codekitchen
added a commit
that referenced
this pull request
Jun 22, 2013
Check if tkellem is running first on tkellem start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure tkellem isn't already running when the user types
tkellem start. If it is running already, print out a relevent
message and exit instead of daemonizing another instance.
Fixes #31