Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Non-ExecutionException Scenarios in CrawlingConfigHelper #2794

Closed
marevol opened this issue Jan 6, 2024 · 0 comments
Closed

Handle Non-ExecutionException Scenarios in CrawlingConfigHelper #2794

marevol opened this issue Jan 6, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@marevol
Copy link
Contributor

marevol commented Jan 6, 2024

We have identified an issue in the CrawlingConfigHelper class where exceptions other than ExecutionException are not adequately handled. This occurs particularly when crawl settings are deleted, leading to unhandled exceptions and potentially causing the crawler to stop.

The proposed change involves modifying the exception handling to catch the generic Exception class instead of specifically catching ExecutionException. This update ensures that any type of exception thrown during the deletion of crawl settings is properly managed, thereby enhancing the robustness of the error handling mechanism.

@marevol marevol added the bug label Jan 6, 2024
@marevol marevol added this to the 14.12.0 milestone Jan 6, 2024
@marevol marevol self-assigned this Jan 6, 2024
@marevol marevol closed this as completed in 1b22604 Jan 6, 2024
marevol added a commit that referenced this issue Jan 6, 2024
…roving stability when crawl settings are deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant