Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Article constructor param sanitization guards #623

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

codelucas
Copy link
Owner

This PR will fix/address the pattern of issues arisen in #562.

This issue is partly a problem with the API since the Article constructor is so brittle, it can take totally incorrect types for input params and still fail silently, misleading the user.

Also remove whitespace.

@codelucas codelucas merged commit 8fa5ae1 into master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant