Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove the deprecated idfaDeclarations field from Relationships #404

Closed
powdream opened this issue May 27, 2024 · 3 comments · Fixed by #405
Closed

Need to remove the deprecated idfaDeclarations field from Relationships #404

powdream opened this issue May 27, 2024 · 3 comments · Fixed by #405

Comments

@powdream
Copy link

Apple seems to have deleted an old field idfaDeclaration from their response in the end.
However, because the field is still alive in the codemagic-tools python lib, the following error happens.

  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/app_store_connect/apps/apps.py", line 125, in list_app_store_versions
    return [AppStoreVersion(app_store_version) for app_store_version in app_store_versions_data]
  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/app_store_connect/apps/apps.py", line 125, in <listcomp>
    return [AppStoreVersion(app_store_version) for app_store_version in app_store_versions_data]
  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/resources/resource.py", line 253, in __init__
    self.relationships = self._create_relationships(api_response)
  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/resources/resource.py", line 245, in _create_relationships
    return cls.Relationships(**defined_fields)
TypeError: __init__() missing 1 required positional argument: 'idfaDeclaration'

The version current we are using is

codemagic-cli-tools==0.51.0
@powdream powdream changed the title Need to remove idfaDeclarations field from Relationships Need to remove the deprecated idfaDeclarations field from Relationships May 27, 2024
@priitlatt
Copy link
Contributor

@powdream thank you for reporting this. We've removed the deprecated field reference and app-store-connect actions work as expected again with new version 0.51.1.

@priitlatt
Copy link
Contributor

#404 (comment) CC @geerpm & @nikocm

@powdream
Copy link
Author

@priitlatt Thanks a lot for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants