-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Store connect latest build number detection improvements #304
Conversation
this change is breaking backward compatibility. I just spent half a day fixing the issue with my deployment pipeline. The default behavior without --expired or --not-expired switches was to return highest build number from builds that weren't expired. After this update, the behavior changed for the older deployment and it started returning highest build number from expired and non-expired combined. This should have remained unchanged. Also, the documentation of the script is not updated so there was no way to quickly figure out what had gone wrong. Can you please make sure to update the documentation? Thanks |
Hi @nouman-hanif. We're terribly sorry for the inconveniences that those changes have brought up to you and your team. In case you have a good idea on how the action documentation should be changed, then please let us know. And, again, sorry for the troubles this has caused you. |
@priitlatt thanks for the explanation. I understand sometimes to improve a solution it is impossible to maintain backward compatibility. The reason it took me more time to figure was because the documentation of the action on GitHub wasn't up to date with the changes. I am talking about readme at get-latest-testflight-build-number. If the two new optional switches Nouman |
@nouman-hanif Web docs for |
great!! @priitlatt :) thanks for the quick update. much appreciated!! |
This is a follow up to PR #300.
The changes that were introduced in #300 expected that when App Store or prerelease versions were listed for an app so that builds are also included in the responses, then there is a correspondence between the included resources (builds in our case) and the queried versions. However this does not always hold and as such the approach can lead to unexpected results.
Changes here choose the highest version (App Store or prerelease) that has builds and then returns the highest build number from this patch of builds.
In addition to this, add mutually exclusive optional arguments
--expired
and--not-expired
to actionapp-store-connect get-latest-testflight-build-number
to include or exclude expired builds from the latest build number lookup. (Fixes #305)Example usage of new flags
Updated actions
app-store-connect get-latest-testflight-build-number
app-store-connect get-latest-app-store-build-number
app-store-connect get-latest-build-number