Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Migrate to Typescript #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

SyedSibtainRazvi
Copy link
Contributor

@SyedSibtainRazvi SyedSibtainRazvi commented Mar 30, 2023

Etiquettes of raising a PR

PR reviews are a way to request peers to give feedback on the code that is going
to the mainline. This means, that PR should be in a reviewable state. Please ensure
that the following checkboxes are ticked. If any of them are not ticked, then
the PR is not ready for review

  • Did you test changes locally?
  • Did you check PR contents after opening the PR

Related issue

Functionalities added or changed

  • Migrated the current project to typescript

Additional info

Checklist

  • Added/Updated Story
  • Tests
  • Translations
  • Documentation
  • Uploaded screenshots
  • Verified on preview URL once

Screenshots

Page(s) if applicable

Device Design Implementation
Desktop ** Figma design screenshot **

Copy link
Contributor

@SujayPrabhu96 SujayPrabhu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting eslintrc & eslintignore files is optional. Can you keep it & see if there is any issue with the builds?

@SyedSibtainRazvi
Copy link
Contributor Author

Sure, we can keep it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants