Fix database connction pool reference handling #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 22, 2023 01:23
…hared, individual execute / fetch operations start a database.connection() context manager to acquire connection from pool
…s global reference self._database
…race conditions can cause unexpected connection termination
…s issued by pydbanitc
codemation
deleted the
fix-database-connction-pool-reference-handling-rb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
everted to connection_map usage, removing connection map timeout as race conditions can cause unexpected connection termination. connection_map remains vital for allowing connections within async tasks. Tasks are not able to share connection pools, and thus need the ability to generate their own pool for use