(Replaced) PowerShell mode for CodeMirror #3910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns recognition). New tests (large scripts). More cleanup.
…ntact you, but please let me know if you have issues with this).
corrected digit matching regex corrected spelling of 'identifier' in grammar dictionary notCharacterOrDash explicitly includes lowercase characters improved variable matching splatted variables now match bare '$' and '@' are errors, not variables moved single-quoted string processing into tokenSingleQuoteString incomplete strings are errors now empty strings are no longer errors added support for here-string interpolation with nesting support added highlighting for splatted vars removed arbitrary stream advancement prior to default error in tokenBase enabled folding braces
…ove\ into mode-powershell
|
@ashmind Can you squash the commits? Thanks. |
| MT('keyword', "[keyword if]"); | ||
|
|
||
| MT('call_builtin', "[builtin Get-ChildItem]"); | ||
| })(); |
There was a problem hiding this comment.
This needs an additional newline afterwards.
|
@Dominator008 I thought about squashing them, but wouldn't that eliminate @benpmiller and @VapidWorx from the history? |
|
@ashmind Maybe squash into three / four commits? |
|
@Dominator008 OK I'll try that. |
|
@Dominator008 Please see #3911. |
ashmind
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PowerShell mode for CodeMirror.
I've done it a while ago, so I don't remember all details, but the following should work well:
${}And I've just added some tests (around 94% code coverage).
Let me know if there are any issues.