This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
feat/migrate-antd5-remove-style-import-codemo #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
grzpab
reviewed
Dec 11, 2023
cjs-builder/index.ts
Outdated
| @@ -28,7 +48,8 @@ | |||
| const options: Parameters<typeof esbuild.build>[0] = { | |||
| entryPoints: [relativeInputFilePath], | |||
| bundle: true, | |||
| packages: 'external', | |||
| // packages: 'external', | |||
| external: getExternal(packageJSON), | |||
There was a problem hiding this comment.
actually we might pass the external package names as the yargs options to the CJS builder OR
We actually remove both packages and external and allow esbuild to bundle the normal dependencies. We will have to move all dependencies to devDependencies
There was a problem hiding this comment.
let do this one
We actually remove both packages and external and allow esbuild to bundle the normal dependencies. We will have to move all dependencies to devDependencies
DmytroHryshyn
force-pushed
the
12-11-feat/migrate-antd5-remove-style-import-codemo
branch
from
c116fe8
to
a71ba5f
Compare
grzpab
reviewed
Dec 12, 2023
cjs-builder/package.json
Outdated
| @@ -6,6 +6,7 @@ | |||
| "cjs-builder": "./dist/index.js" | |||
| }, | |||
| "scripts": { | |||
| "build": "esbuild ./index.ts --bundle --platform=node --target=node16 --format=esm --outfile=./dist/index.js --external:esbuild", | |||
grzpab
reviewed
Dec 12, 2023
| @@ -3,6 +3,9 @@ import esbuild from 'esbuild'; | |||
| import { mkdir, readFile, writeFile } from 'node:fs/promises'; | |||
| import { dirname, join } from 'node:path'; | |||
|
|
|||
| // list of packages that should be bundled to the codemod (e.g codemod internal utils) | |||
| const EXTERNAL_DEPENDENCIES = ['jscodeshift', 'ts-morph']; | |||
There was a problem hiding this comment.
hmm what about @intuita-inc/filemod?
There was a problem hiding this comment.
we only import types from it, so its fine
grzpab
approved these changes
Dec 12, 2023
DmytroHryshyn
deleted the
12-11-feat/migrate-antd5-remove-style-import-codemo
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.