This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
feat/migrate-antd-removed-component-migration #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
grzpab
reviewed
Dec 11, 2023
| @@ -0,0 +1,27 @@ | |||
| { | |||
| "name": "@codemod-registry/antd-5-v5-remove-style-import", | |||
There was a problem hiding this comment.
this name is odd, how did it happen?
grzpab
reviewed
Dec 11, 2023
codemods/antd/5/utils/marker.js
Outdated
| ); | ||
| } | ||
|
|
||
| async function getDependencies() { |
There was a problem hiding this comment.
is this used anywhere? I think it will crash as direct FS operations are unsupported in our model of execution.
There was a problem hiding this comment.
only markDependency is used, but its also using fs. Should we reimplement this codemod as Filemod?
There was a problem hiding this comment.
I would remove the parts that are not used and comment out the usage of mark dependency. We may consider moving to a filemod later on.
DmytroHryshyn
force-pushed
the
12-11-feat/migrate-antd5-remove-style-import-codemo
branch
from
c116fe8
to
a71ba5f
Compare
DmytroHryshyn
force-pushed
the
feat/removed-component-migration
branch
2 times, most recently
from
7cb8989
to
98c79fd
Compare
Base automatically changed from
12-11-feat/migrate-antd5-remove-style-import-codemo
to
main
December 12, 2023 10:19
DmytroHryshyn
force-pushed
the
feat/removed-component-migration
branch
from
98c79fd
to
7519961
Compare
grzpab
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/migrate-antd-removed-component-migration
feat/migrate-antd-removed-component-migration