PHPCS/Composer: update PHPCompatibility #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer:
* `wimg/php-compatibility` has been abandoned for nearly a year. Use `phpcompatibility/php-compatibility` instead.
* Use the latest version of PHPCompatibility.
You were missing out on a lot of new checks, including the checks to make sure your code is compatible with the upcoming PHP 7.4.
* Use the latest version of the DealerDirect Composer PHPCS plugin.
Composer treats minors < 1.0 as majors, so you need to explicitely update.
PHPCS PHPCompatibility ruleset:
* No need to set the `date.timezone`. That sniff has been removed for quite a while now.
Refs:
* https://github.com/PHPCompatibility/PHPCompatibility/releases/
* https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases
|
Any chance that this PR can get some love ? |
|
Actually yes since I might do some work on the repo soon. You know how it is, private stuff is always pushed back in favor of the "office needs". |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer:
wimg/php-compatibilityhas been abandoned for nearly a year. Usephpcompatibility/php-compatibilityinstead.You were missing out on a lot of new checks, including the checks to make sure your code is compatible with the upcoming PHP 7.4.
Composer treats minors < 1.0 as majors, so you need to explicitely update.
PHPCS PHPCompatibility ruleset:
date.timezone. That sniff has been removed for quite a while now.Refs: