Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate options of Codenvy bootstrap script #404

Closed
vkuznyetsov opened this issue Jul 19, 2016 · 1 comment
Closed

Validate options of Codenvy bootstrap script #404

vkuznyetsov opened this issue Jul 19, 2016 · 1 comment

Comments

@vkuznyetsov
Copy link

Validate options which user passes to Codenvy bootstrap script.
If option is unknown, display warning at start like the follow:
{noformat}
[CODENVY] Welcome. This program installs Codenvy 3.14.2-SNAPSHOT.
[CODENVY] !!! You passed a parameter named no-proxy. This is an unrecognized parameter.
[CODENVY] !!! You passed a parameter named http-proxy. This is an unrecognized parameter.
[CODENVY] !!! You passed a parameter named https-proxy. This is an unrecognized parameter.
[CODENVY] Proceed? [y/N]
{noformat}

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Aug 1, 2016

I propose to change output slightly to handle parameters with value, flags and typos:

[vagrant@dev ~]$ ./install-codenvy.sh --http-proxy=http://test --unknown typo
parameter_validation_output

dmytro-ndp pushed a commit that referenced this issue Aug 1, 2016
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
dmytro-ndp pushed a commit that referenced this issue Aug 1, 2016
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
dmytro-ndp pushed a commit that referenced this issue Aug 1, 2016
(#404) validate options of Codenvy bootstrap script
dmytro-ndp pushed a commit that referenced this issue Aug 1, 2016
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
dmytro-ndp pushed a commit that referenced this issue Aug 2, 2016
fixup! (#404) validate options of Codenvy bootstrap script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants