CODENVY-1009: fix license legality check #1011
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riuvshin License legality on nightly5 should be checked, cause now it's false. |
benoitf
approved these changes
Oct 23, 2016
|
@ashumilova nightly5 is not onprem it is saas we can't check this on saas |
olexii4
approved these changes
Oct 24, 2016
|
Then saas should not have license service deployed, if it's not used, or it should return correct value, like on beta now. Not sure, but the result of this issue #599 may cause it. |
akurinnoy
approved these changes
Oct 24, 2016
Signed-off-by: Ann Shumilova <ashumilova@codenvy.com>
ashumilova
force-pushed
the
CODENVY-1009
branch
from
513a217
to
7fe7ba4
Compare
|
@riuvshin, @ashumilova: https://codenvy.io has Codenvy license and so it returns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix license legality check.
What issues does this PR fix or reference?
#1009
Signed-off-by: Ann Shumilova ashumilova@codenvy.com