Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate jdk image #1355

Merged
merged 2 commits into from
Dec 15, 2016
Merged

eliminate jdk image #1355

merged 2 commits into from
Dec 15, 2016

Conversation

riuvshin
Copy link

We have to remove that dockerfile and stop using that image same way as in che.
We even didn't used this image in version manifest file https://github.com/codenvy/codenvy/blob/master/dockerfiles/cli/version/latest/images

/opt/codenvy-data/conf /opt/codenvy-data/conf/logback \
/opt/codenvy-data/license

CMD [ "postfix", "-c", "/etc/postfix", "start" ]

RUN set -x \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that this RUN instruction should be merged with the previous run instruction ?

@benoitf
Copy link
Contributor

benoitf commented Dec 15, 2016

this block

COPY dockerfiles/codenvy/entrypoint.sh /
RUN chmod +x entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]

could be before lines

ADD assembly/onpremises-ide-packaging-tomcat-codenvy-allinone/target/onpremises-ide-packaging-tomcat-codenvy-allinone-*.zip /
RUN unzip -q onpremises-ide-packaging-tomcat-codenvy-allinone-*.zip -d /opt/codenvy-tomcat && rm onpremises-ide-packaging-tomcat-codenvy-allinone-*.zip

as we change more often the zip than the entrypoint

@riuvshin
Copy link
Author

@benoitf updated

@riuvshin riuvshin merged commit 1309921 into master Dec 15, 2016
@riuvshin riuvshin deleted the eliminate_jdk_image branch December 15, 2016 11:09
benoitf pushed a commit that referenced this pull request Dec 20, 2016
* eliminate jdk image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants