CODENVY-1271: refactor projects backuping #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garagatyi
requested review from
skabashnyuk,
mshaposhnik,
sleshchenko and
akorneta
sleshchenko
approved these changes
Dec 19, 2016
| } | ||
|
|
||
| @ScheduleRate(initialDelay = 1, period = 1, unit = TimeUnit.MINUTES) | ||
| public void scheduleBackup() { | ||
| for (Map.Entry<String, WorkspaceRuntimes.WorkspaceState> wsStateEntry : | ||
| workspaceRuntimes.getWorkspaces().entrySet()) { | ||
|
|
||
| String workspaceId = wsStateEntry.getKey(); |
There was a problem hiding this comment.
I don't see usage of wsStateEntry.getValue(). Would it better to use workspaceRuntimes.getWorkspaces().keySet() for loop?
There was a problem hiding this comment.
ok, Ill fix that. Thanks.
| srcUserName, | ||
| destPath); | ||
| } catch (IOException | ServerException e) { | ||
| throw new ServerException(e.getLocalizedMessage(), e); |
There was a problem hiding this comment.
Why you should catch ServerException to rethrow it as ServerException?
akorneta
approved these changes
Dec 19, 2016
mshaposhnik
approved these changes
Dec 19, 2016
skabashnyuk
approved these changes
Dec 19, 2016
garagatyi
force-pushed
the
bitnamiFix
branch
from
857b802
to
19d35ea
Compare
Refactor projects backuping. Detect user in dev-machine container to backup projects.
garagatyi
force-pushed
the
bitnamiFix
branch
from
19d35ea
to
f513de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor projects backuping.
Detect user in dev-machine container to backup projects.
What issues does this PR fix or reference?
Fixes #1271
Previous Behavior
Restoring of workspaces created from images without rsync failed.
New Behavior
Such workspaces starts well.
Tests written?
Yes