-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ports for install guide #1412
Conversation
Don't merge this without a review from me. I am not sure we want to communicate this information like this. |
|Port|Service|Notes| | ||
|---|---|---| | ||
|80 / 443|HAProxy HTTP/S|HTTP is the default. If you configure [HTTP/S]({{base}}/docs/admin-guide/configuration/index.html#https), then port 80 can be closed. | ||
|5000|Docker Registry|Embedded registry to save workspace snapshots. This port is not required if you configure an external registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, opening 5000 port for the registry is a must for AIO+ nodes so that other nodes can pull from the registry. Not mandatory for AIO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a simplification of the documentation, we are going to treat the system as if there is only one configuration - AIO+. So it does not hurt to show additional ports if you are only running AIO. It'll be simpler to maintain.
But doesn't 5000 need to be open on both master and workspace nodes so that they can communicate back and forth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerJewell - I'm going to move the docs back to being more explicit about the AIO and AIO+ models. It adds a little complexity, but people are very concerned about what ports need to be opened so I'd rather be very clear here so they are opening up the minimum number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need port 5000 on a workspace node. Just master node, and only if you have at least one workspace node. Moreover, this port may be available just for the nodes and closed for other connections.
#### Workspace Node: Internal | ||
|Port|Service | ||
|---|---| | ||
|81|Nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nginx is running on a master node
|81|Nginx | ||
|2375|Swarm | ||
|2376|ZooKeeper | ||
|5432|Postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|2375|Swarm | ||
|2376|ZooKeeper | ||
|5432|Postgres | ||
|8080|Codenvy Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|Port|Service | ||
|---|---| | ||
|81|Nginx | ||
|2375|Swarm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swarm isn't running on a machine node. So, this port isn't required.
|---|---| | ||
|81|Nginx | ||
|2375|Swarm | ||
|2376|ZooKeeper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zookeeper, once run, will be running on a master node, and Docker daemon running on a machine node will connect to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|---|---| | ||
|81|Nginx | ||
|2375|Swarm | ||
|2376|ZooKeeper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port is 2181
#### Workspace Node: Internal | ||
|Port|Service | ||
|---|---| | ||
|2181|ZooKeeper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need this port on a workspace node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's internal - so don't you need an outbound port communication flow from the workspace node to the master? What I did was add open all of the outbound ports that flow from a workspace node back to the master node. So don't you need an outbound port open for each of those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outbound is a keyword here, yeah!
What does this PR do?
Adds port information for Codenvy install guide.