Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ports for install guide #1412

Merged
merged 8 commits into from
Dec 23, 2016
Merged

Update ports for install guide #1412

merged 8 commits into from
Dec 23, 2016

Conversation

bmicklea
Copy link
Contributor

@bmicklea bmicklea commented Dec 22, 2016

What does this PR do?

Adds port information for Codenvy install guide.

@bmicklea bmicklea requested a review from a user December 22, 2016 17:03
@TylerJewell
Copy link
Contributor

Don't merge this without a review from me. I am not sure we want to communicate this information like this.

|Port|Service|Notes|
|---|---|---|
|80 / 443|HAProxy HTTP/S|HTTP is the default. If you configure [HTTP/S]({{base}}/docs/admin-guide/configuration/index.html#https), then port 80 can be closed.
|5000|Docker Registry|Embedded registry to save workspace snapshots. This port is not required if you configure an external registry.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, opening 5000 port for the registry is a must for AIO+ nodes so that other nodes can pull from the registry. Not mandatory for AIO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a simplification of the documentation, we are going to treat the system as if there is only one configuration - AIO+. So it does not hurt to show additional ports if you are only running AIO. It'll be simpler to maintain.

But doesn't 5000 need to be open on both master and workspace nodes so that they can communicate back and forth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerJewell - I'm going to move the docs back to being more explicit about the AIO and AIO+ models. It adds a little complexity, but people are very concerned about what ports need to be opened so I'd rather be very clear here so they are opening up the minimum number.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need port 5000 on a workspace node. Just master node, and only if you have at least one workspace node. Moreover, this port may be available just for the nodes and closed for other connections.

#### Workspace Node: Internal
|Port|Service
|---|---|
|81|Nginx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nginx is running on a master node

|81|Nginx
|2375|Swarm
|2376|ZooKeeper
|5432|Postgres
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

|2375|Swarm
|2376|ZooKeeper
|5432|Postgres
|8080|Codenvy Server
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

|Port|Service
|---|---|
|81|Nginx
|2375|Swarm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swarm isn't running on a machine node. So, this port isn't required.

|---|---|
|81|Nginx
|2375|Swarm
|2376|ZooKeeper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zookeeper, once run, will be running on a master node, and Docker daemon running on a machine node will connect to it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

|---|---|
|81|Nginx
|2375|Swarm
|2376|ZooKeeper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port is 2181

#### Workspace Node: Internal
|Port|Service
|---|---|
|2181|ZooKeeper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this port on a workspace node

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's internal - so don't you need an outbound port communication flow from the workspace node to the master? What I did was add open all of the outbound ports that flow from a workspace node back to the master node. So don't you need an outbound port open for each of those?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outbound is a keyword here, yeah!

@bmicklea bmicklea merged commit 485b0df into master Dec 23, 2016
@bmicklea bmicklea deleted the doc-install-ports branch December 23, 2016 14:22
@bmicklea bmicklea restored the doc-install-ports branch December 23, 2016 14:24
@bmicklea bmicklea deleted the doc-install-ports branch December 23, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants