CODENVY-1392: fix sync agent start check #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change way of verification that sync agent is launched in machine.
skabashnyuk
reviewed
Dec 27, 2016
| super(agentMaxStartTimeMs, | ||
| agentPingDelayMs, | ||
| new CompositeAgentLaunchingChecker(new CommandExistsAgentChecker("rsync"), | ||
| AgentLaunchingChecker.DEFAULT)); |
There was a problem hiding this comment.
are you sure it's good idea to create objects here, may be we should delegate it to container?
There was a problem hiding this comment.
Do you suggest to create ExternalRsyncAgentLauncherImpl in module instead or smth else?
skabashnyuk
approved these changes
Dec 27, 2016
tolusha
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change way of verification that sync agent is launched in machine.
What issues does this PR fix or reference?
Fixes #1392
Previous Behavior
Start of WS sometimes failed when ssh or/and rsync are not installed in container.
New Behavior
Start of WS finishes successfully when ssh or/and rsync are not installed in container.
Tests written?
No