in dev mode use agents from the repo same way as api server #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garagatyi
reviewed
Dec 27, 2016
| # path to codenvy ws agent for development mode | ||
| $codenvy_development_ws_agent = getValue("WS_AGENT_ASSEMBLY","/path/to/codenvy_tomcat") | ||
| # path to codenvy terminal agent for development mode | ||
| $codenvy_development_terminal_agent = getValue("TERMINAL_AGENT_ASSEMBLY","/path/to/codenvy_tomcat") |
There was a problem hiding this comment.
Terminal is not related to tomcat server. Why it is on such path?
There was a problem hiding this comment.
this is "default" path which never be used as we always set this in CLI but I agree i will update this to be more clear, thanks
garagatyi
reviewed
Dec 27, 2016
| @@ -174,6 +174,26 @@ cmd_config_post_action() { | |||
| log "docker volume create --name=codenvy-postgresql-volume >> \"${LOGS}\"" | |||
| docker volume create --name=codenvy-postgresql-volume >> "${LOGS}" | |||
| fi | |||
|
|
|||
| if [ "${CHE_DEVELOPMENT_MODE}" = "on" ]; then | |||
There was a problem hiding this comment.
Maybe we should have single folder with agents instead of adding small peace of code in this script on addition of each agent?
There was a problem hiding this comment.
in fact all agents will appear in single dir
garagatyi
approved these changes
Dec 27, 2016
TylerJewell
approved these changes
Dec 27, 2016
|
@TylerJewell I've updated PR, can you please review changes, I changed some ENV vars names to be more clear. |
TylerJewell
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes needed for #1431
Those changes affects ONLY dev mode.
to make dev mode consistent we have to pick agents (ws agent and terminal) same way as api server to containers from
:/repo@TylerJewell @benoitf please carefully review this I want to be sure I didn't missed anything
This change is