Fix license error message in case of license doesn't expire #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolusha
approved these changes
Dec 29, 2016
| try { | ||
| // when license exists | ||
| SystemLicense license = load(); // check if license exists | ||
| if (license.isExpiredCompletely()) { |
There was a problem hiding this comment.
What is the reason to name method isExpiredCompletely? How does it differ from isExpired ?
Consider split methods into two separated.
There was a problem hiding this comment.
isExpiredCompletely = isExpired + additional time for renew license.
added 2 commits
December 29, 2016 11:12
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
…rRenewExpired() methods Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
dmytro-ndp
force-pushed
the
license_fix
branch
from
b3d480f
to
6a78aa5
Compare
|
@tolusha: I have splitted SystemLicense.isExpiredCompletely() on isExpired() and isTimeForRenewExpired() methods, as you suggested. |
|
Cool. thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmytro Nochevnov dnochevnov@codenvy.com
What does this PR do?
Fix error message on start of workspace by non-admin user in case of number of registered users more than license allows, but license hasn't expired yet.
Previous misleading message:
Fixed message
@tolusha: please, review this request.
This change is