-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postflight check of swarm nodes #1637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
@benoitf - as part of the testing, I would ask for you to adapt ARTIK and Codenvy SAAS to do the same. Note that there was a small refactoring of the method names and how I make use of pre_init and post_init in Che. |
TylerJewell
changed the title
Refactor CLI to derive usage() method
Add postflight check of swarm nodes
Jan 30, 2017
Mattlk13
approved these changes
Jan 30, 2017
Change-Id: I8499dc622ca10b2cdc96f7dc1ba7fb1da9fd9ac5 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
approved these changes
Jan 31, 2017
I've updated methods name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Jewell tjewell@codenvy.com
What does this PR do?
This PR adapts changes made to Eclipse Che to allow the inherited CLI to inherit its
usage()
statement from the core CLI so that as the base CLI makes improvements, the new CLI will have it inherited automatically.Also provides a first implementation of a postflight check, which pulls the list of Swarm nodes from
codenvy.env
and then usescurl
to ping each one's/info
URL to see if it is reachable.Must merge this at the same time as we merge: eclipse-che/che#3940
Changelog
Adapt CLI to changes in Eclipse Che #3940 and add postflight check of Swarm nodes as a test
Release Notes
We are working to make sure Codenvy starts in any environment perfectly every time. We've added some additional preflight checks related to mandatory minimums for disk and memory available from the host. If the minimums are not enough to start at least one workspace, then Codenvy bootup will be interrupted. Preflight checks can now be skipped with either
--fast
or--skip:preflight
on the command line.We have also introduced postflight checks. We parse
codenvy.env
to get a list of Swarm nodes for your cluster. We then check that each is reachable using curl and that their/info
URL is returning valid data. A failure of this command is an early indicator that firewalls were not configured correctly. You can skip this check with--fast
or--skip:postflight
.Docs PR
codenvy/docs#59