Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postflight check of swarm nodes #1637

Merged
merged 8 commits into from
Jan 31, 2017
Merged

Add postflight check of swarm nodes #1637

merged 8 commits into from
Jan 31, 2017

Conversation

TylerJewell
Copy link
Contributor

@TylerJewell TylerJewell commented Jan 29, 2017

Signed-off-by: Tyler Jewell tjewell@codenvy.com

What does this PR do?

This PR adapts changes made to Eclipse Che to allow the inherited CLI to inherit its usage() statement from the core CLI so that as the base CLI makes improvements, the new CLI will have it inherited automatically.

Also provides a first implementation of a postflight check, which pulls the list of Swarm nodes from codenvy.env and then uses curl to ping each one's /info URL to see if it is reachable.

Must merge this at the same time as we merge: eclipse-che/che#3940

Changelog

Adapt CLI to changes in Eclipse Che #3940 and add postflight check of Swarm nodes as a test

Release Notes

We are working to make sure Codenvy starts in any environment perfectly every time. We've added some additional preflight checks related to mandatory minimums for disk and memory available from the host. If the minimums are not enough to start at least one workspace, then Codenvy bootup will be interrupted. Preflight checks can now be skipped with either --fast or --skip:preflight on the command line.

We have also introduced postflight checks. We parse codenvy.env to get a list of Swarm nodes for your cluster. We then check that each is reachable using curl and that their /info URL is returning valid data. A failure of this command is an early indicator that firewalls were not configured correctly. You can skip this check with --fast or --skip:postflight.

Docs PR

codenvy/docs#59

Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
@TylerJewell
Copy link
Contributor Author

@benoitf - as part of the testing, I would ask for you to adapt ARTIK and Codenvy SAAS to do the same. Note that there was a small refactoring of the method names and how I make use of pre_init and post_init in Che.

@TylerJewell TylerJewell changed the title Refactor CLI to derive usage() method Add postflight check of swarm nodes Jan 30, 2017
Change-Id: I8499dc622ca10b2cdc96f7dc1ba7fb1da9fd9ac5
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf
Copy link
Contributor

benoitf commented Jan 31, 2017

I've updated methods name

@TylerJewell TylerJewell merged commit 61e7f7a into master Jan 31, 2017
@TylerJewell TylerJewell deleted the cli-refactoring branch January 31, 2017 20:23
@JamesDrummond JamesDrummond added this to the 5.2.0 milestone Feb 2, 2017
@JamesDrummond JamesDrummond mentioned this pull request Feb 6, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants