Openjdk instead of oracle jdk #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
riuvshin
approved these changes
Feb 10, 2017
skabashnyuk
approved these changes
Feb 10, 2017
|
change log |
added 2 commits
February 10, 2017 12:31
|
@skabashnyuk @benoitf used |
benoitf
reviewed
Feb 10, 2017
dockerfiles/codenvy/Dockerfile
Outdated
| /opt/jdk/jre/lib/plugin.jar \ | ||
| /tmp/* /var/cache/apk/* && \ | ||
| echo 'hosts: files mdns4_minimal [NOTFOUND=return] dns mdns4' >> /etc/nsswitch.conf && \ | ||
| RUN echo "http://dl-4.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories && \ |
There was a problem hiding this comment.
for which packages "edge/community" is required ?
There was a problem hiding this comment.
also why do we need mc there ?
|
removed edge unzip and mc |
bmicklea
approved these changes
Feb 10, 2017
benoitf
approved these changes
Feb 10, 2017
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use official openjdk image
Changelog
Switch to OpenJDK, use official OpenJDK image as parent.