Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up outdated bindings in API servlet module #1755

Merged
merged 9 commits into from
Feb 22, 2017
Merged

Conversation

mkuznyetsov
Copy link
Contributor

@mkuznyetsov mkuznyetsov commented Feb 10, 2017

What does this PR do?

Remove outdated bindings in OnPremisesApiServletModule

What issues does this PR fix or reference?

#1587

Changelog

Cleaned up outdated API servlet module bindings.

Release Notes

N/A

@skabashnyuk
Copy link
Contributor

@codenvy/pm review

@@ -52,31 +49,15 @@
"/github/*",
"/bitbucket/*",
"/ssh-keys/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we need this binding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, I removed it

@bmicklea bmicklea self-requested a review February 10, 2017 13:16
@JamesDrummond
Copy link

Removed doc section and added N/A for release notes.

@skabashnyuk skabashnyuk added this to the 5.4.0 milestone Feb 20, 2017
@mkuznyetsov mkuznyetsov merged commit ac3c677 into master Feb 22, 2017
@mkuznyetsov mkuznyetsov deleted the codenvy-1587 branch February 22, 2017 05:31
akorneta pushed a commit to sleshchenko/codenvy that referenced this pull request Feb 23, 2017
* Clean-up outdated bindings in API servlet module

* fixup! Clean-up outdated bindings in API servlet module

* fixup! fixup! Clean-up outdated bindings in API servlet module

* fixup! Merge branch 'master' of github.com:codenvy/codenvy into codenvy-1587
@JamesDrummond JamesDrummond mentioned this pull request Mar 8, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants