-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up outdated bindings in API servlet module #1755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@codenvy/pm review |
sleshchenko
reviewed
Feb 10, 2017
@@ -52,31 +49,15 @@ | |||
"/github/*", | |||
"/bitbucket/*", | |||
"/ssh-keys/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that we need this binding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, I removed it
bmicklea
approved these changes
Feb 10, 2017
Removed doc section and added N/A for release notes. |
vparfonov
approved these changes
Feb 13, 2017
skabashnyuk
approved these changes
Feb 21, 2017
akorneta
pushed a commit
to sleshchenko/codenvy
that referenced
this pull request
Feb 23, 2017
* Clean-up outdated bindings in API servlet module * fixup! Clean-up outdated bindings in API servlet module * fixup! fixup! Clean-up outdated bindings in API servlet module * fixup! Merge branch 'master' of github.com:codenvy/codenvy into codenvy-1587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove outdated bindings in OnPremisesApiServletModule
What issues does this PR fix or reference?
#1587
Changelog
Cleaned up outdated API servlet module bindings.
Release Notes
N/A