CODENVY-1711: Grant permissions to admins for predefined stacks #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
reviewed
Feb 13, 2017
| @@ -86,8 +103,66 @@ public void filter(GenericResourceMethod genericResourceMethod, Object[] argumen | |||
| throw new ForbiddenException("The user does not have permission to perform this operation"); | |||
| } | |||
|
|
|||
| if (currentSubject.hasPermission(SystemDomain.DOMAIN_ID, stackId, SystemDomain.MANAGE_SYSTEM_ACTION) | |||
There was a problem hiding this comment.
currentSubject.hasPermission(SystemDomain.DOMAIN_ID, null, SystemDomain.MANAGE_SYSTEM_ACTION)
sleshchenko
reviewed
Feb 13, 2017
| return permissionsManager.getByInstance(DOMAIN_ID, stackId, 25, 0); | ||
| } | ||
| if (!permissionsPage.hasNextPage()) { | ||
| return null; |
There was a problem hiding this comment.
I don't think that it is good idea to return null here
…te and delete to predefined stacks Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
mmorhun
force-pushed
the
CODENVY-1711
branch
from
3eaf098
to
22664ca
Compare
|
ci-build |
|
Add yourself as author to StackPermissionsFilter please |
sleshchenko
approved these changes
Feb 16, 2017
skabashnyuk
approved these changes
Feb 16, 2017
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
|
These will appear in Swagger docs, right? |
|
@bmicklea no, it will just perform action instead of error with permission denied message in case of predefined stack. |
bmicklea
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows to users with
manageSystempermission perform edit and delete operation with predefined (i.e. public for all users) stack.What issues does this PR fix or reference?
#1711
Changelog
Permissions granted to admins to perform
updateanddeleteaction with predefined stacks.Release Notes
Added ability to admins with
manageSystempermission performupdateanddeleteaction with predefined stacks.Docs PR
N/A