CODENVY-1749: add possibility to set DNS resolver #1771
Conversation
garagatyi
requested review from
TylerJewell,
benoitf,
skabashnyuk and
riuvshin
|
@codenvy/pm Please review |
| @@ -272,6 +272,10 @@ | |||
| # please leave this as it is if you don't need no_proxy configuration | |||
| $no_proxy_for_codenvy_workspaces = getValue("CODENVY_NO_PROXY_FOR_CODENVY_WORKSPACES","") | |||
|
|
|||
| ################################ | |||
| # DNS resolver configuration | |||
| $dns_resolvers = getValue("CODENVY_DNS_RESOLVERS","") | |||
There was a problem hiding this comment.
default value must be 'NULL' because you check on 'NULL' in template
| @@ -62,8 +62,7 @@ error_log /var/log/nginx/error.log error; | |||
| #gzip_proxied expired no-cache no-store private auth; | |||
| #gzip_types text/plain text/css text/xml text/javascript application/x-javascript application/xml; | |||
|
|
|||
| resolver 127.0.0.1 8.8.8.8 ipv6=off; | |||
|
|
|||
| resolver <% if @dns_resolvers.empty? -%>8.8.8.8<% else -%><%= @dns_resolvers.gsub(',', ' ') %><% end -%> ipv6=off; | |||
There was a problem hiding this comment.
you shoul che on != 'NULL' same as in compose file if @dns_resolvers != 'NULL'
|
Needs docs. Waiting on associated Che doc review before creating it for codenvy. |
|
@riuvshin I fixed PR. |
| @@ -62,8 +62,7 @@ error_log /var/log/nginx/error.log error; | |||
| #gzip_proxied expired no-cache no-store private auth; | |||
| #gzip_types text/plain text/css text/xml text/javascript application/x-javascript application/xml; | |||
|
|
|||
| resolver 127.0.0.1 8.8.8.8 ipv6=off; | |||
|
|
|||
| resolver <% if @dns_resolvers != 'NULL' -%>8.8.8.8<% else -%><%= @dns_resolvers.gsub(',', ' ') %><% end -%> ipv6=off; | |||
There was a problem hiding this comment.
if statement look strange maybe I was confused you by asking check != null
but seems in that case it should looks like
<% if @dns_resolvers == 'NULL' -%>8.8.8.8<% else -%><%= @dns_resolvers.gsub(',', ' ') %><% end -%>
otherwise 8.8.8.8 will never be by defaul
|
@riuvshin I had to rework PR, so now empty string is used instead of NULL. It is needed because Java code can't interpret NULL as empty array |
|
@garagatyi I saw this and approved |
|
@garagatyi was the merged to 5.3? There's no milestone set. |
bmicklea
changed the title
What does this PR do?
Add possibility to set DNS resolving servers.
If Codenvy is set to use custom DNS that is resolvable using custom DNS resolving server admin should set env var: CODENVY_DNS_RESOLVERS
It may contain several values in comma-separated format, e.g.
What issues does this PR fix or reference?
Fixes #1749
Changelog
Add possibility to set DNS resolving servers.
Release Notes
We now let you override the default DNS resolvers that are created in your workspace runtimes. In Codenvy, each workspace is given a set of runtimes. Agents and other services that run within those runtimes inherit networking properties from Che including proxy and security configuration. In some environments, custom resolution of DNS entries (usually to an internal DNS provider) is required to enable the workspace runtimes to have lookup ability from services within the workspace. You can now add
CODENVY_DNS_RESOLVERS=<ip-list>tocodenvy.envto customize the DNS injection into default containers. The default behavior is to inherit the list of DNS resolver servers from the host.Docs PR
??