-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODENVY-1758; add OAuth2 authenticator for Linkedin #1791
Conversation
LinkedInOauthAuthenticator -> LinkedInOAuthAuthenticator |
final String query = String.format("format=json"); | ||
JsonValue userValue = doRequest(new URL(userUri + ":" + values + "?" + query), params); | ||
User user = new LinkedInUser(); | ||
user.setEmail(userValue.getElement("emailAddress").getStringValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should check existance userValue.getElement("emailAddress")
of this element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icons for linkedin oauth btn will be added in https://github.com/codenvy/enterprise/issues/48
@codenvy/pm please approve |
Release notes need to be revisited. The changelog is ok but the release notes are meant for marketing. So we should talk about how to configure it within configuration, are there any logos that appear, and whether there is a difference between onprem and saas. |
To be clear:
PM will take this information and update the release note section with it. |
@bmicklea |
This will need docs. Not sure if I like the look and it doesn't include the other oauth links. I would think round corners like the google oauth icon below and also its not the same size/height of other information on the row. WDYT @bmicklea . Update: Sorry I didn't look at saas(customers) or onprem. Looks like @mshaposhnik image above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge
@mshaposhnik where are those variables found (and it looks like you listed the same one twice, are there two?) I don't see them in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation updated.
@bmicklea Think @mshaposhnik meant |
Thanks, I still don't see them in the |
Thanks Sergii. I don't think we usually want people messing with the |
@bmicklea You are looking at the wrong file on the link. The link https://github.com/codenvy/codenvy/pull/1791/files#diff-4e1211b38190902dee42a5833ea2efb5R466 highlights code for |
What does this PR do?
Added OAuth2 authentication via LinkedIn. Configured via codenvy.env file with following variables:
What issues does this PR fix or reference?
#1758
Changelog
Added oAuth2 authentication via LinkedIn.
Release Notes
We have added a new oAuth provider to Codenvy. You can now use your LinkedIn credentials to sign up or sign in.
Docs PR
codenvy/docs#81