Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "INFRA-68; remove compiling-ide module (#1766)" #1842

Merged
merged 4 commits into from
Mar 1, 2017

Conversation

mkuznyetsov
Copy link
Contributor

@mkuznyetsov mkuznyetsov commented Feb 28, 2017

This reverts commit fd4fa31. related to #1766

What does this PR do?

Going back to have a module for compiling GWT for IDE, and another module for it's assembly. It is needed, to be able to reuse GWT sources in other assemblies (like archetype samples), as well as keep assembly-ide-war clean

What issues does this PR fix or reference?

Changelog

This reverts PR #1766

Docs PR

codenvy/docs#86

@skabashnyuk
Copy link
Contributor

@bmicklea @JamesDrummond note after we merge this pr
Docs and changes log from #1766 this pr have to be reverted too.

@skabashnyuk
Copy link
Contributor

Right now we trying to solve a couple of issues.

  1. We want to not to include gwt dependencies that need for gwt compilation in resulting war.
  2. We want to include runtime(not gwt related) jars in resulting war.
  3. We want to be able to have a single artifact so plugin developers can include it to his gwt compiling war.
  4. In future we would like to decentralize gwt.xml between many maven artifacts.

In this pr #1766 we solve 1-2 but forget about 3.
I also have discussion about maven structure of gwt compiling with @benoitf and @vparfonov
During this discussion we have an idea to create uber jar with gwt dependencies but it conflicts 4 Other idea was to keep gwt dependencies as provided but generate classes war dependency during build. But it require to write new maven plugin and we decided to postpone this task.

@skabashnyuk skabashnyuk added this to the 5.4.0 milestone Mar 1, 2017
@bmicklea bmicklea removed the request for review from JamesDrummond March 1, 2017 10:04
@mkuznyetsov mkuznyetsov merged commit e47e043 into master Mar 1, 2017
@mkuznyetsov mkuznyetsov deleted the revert-infra-68 branch March 1, 2017 13:14
@JamesDrummond JamesDrummond mentioned this pull request Mar 8, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants