CODENVY-1739: Do not make additional http request on each license check #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 22, 2017 16:23
|
Will it cache requests if license is NOT accepted? |
|
It shouldn't. |
|
Ok. And what is the problem? What if it will be 1 minute? And the opposite task. If license was ok but expired during tomcat life time should it be revalidated after X minutes? |
I user could login after license had been accepted it would be awkward.
Agree. |
skabashnyuk
approved these changes
Mar 2, 2017
tolusha
approved these changes
Mar 2, 2017
bmicklea
approved these changes
Mar 2, 2017
|
ci-build |
riuvshin
pushed a commit
that referenced
this pull request
Mar 6, 2017
…ck (#1863) CODENVY-1739: Do not make additional http request on each Fair Source License check in SystemLicenseLoginFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Caches Fair Source License acceptance to prevent multiple requests with the same result.
What issues does this PR fix or reference?
#1739
Changelog
Optimizes Fair Source license checks to improve performance.
Release Notes
We've optimized the performance of all HTTP requests by caching the necessary license checks.