Reduce the number of requests to the storage to retrieve the total number of users #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolusha
changed the title
|
@tolusha: does it depend on eclipse-che/che#4478 ? |
|
Yes, they both have the same reference issue. |
dmytro-ndp
reviewed
Mar 20, 2017
| return currentUsersNumber; | ||
| } | ||
| } catch (ServerException e) { | ||
| LOG.error("Can't get total users number. License checking might be inconsistent.", e); |
There was a problem hiding this comment.
Actually, license checking is impossible in this case.
| @@ -383,7 +388,7 @@ public void shouldRollbackTransactionWhenFailedToRemoveAnyOfEntries( | |||
|
|
|||
| // Remove the user, all entries must be rolled back after fail | |||
| try { | |||
| userDao.remove(user2.getId()); | |||
| userManager.remove(user2.getId()); | |||
| fail("UserDao#remove had to throw exception"); | |||
There was a problem hiding this comment.
There is UserManager#remove method is called.
dmytro-ndp
approved these changes
Mar 20, 2017
skabashnyuk
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Caches the total number number of user.
Refreshes cache if the number has been changed based on fired events.
What issues does this PR fix or reference?
#1923
Changelog
Reduce the number of requests to the storage to retrieve the total number of users
Release Notes
not required
Docs PR
not required