CODENVY-1734: workaround docker exec not found problem in swarm #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorhun
reviewed
Mar 29, 2017
| logMissingExecInfo(params.getExecId()); | ||
| try { | ||
| // Wait in case swarm needs some time to find exec | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
I'm afraid that 1 second could be not enough. Please set longer delay (maybe 5 seconds is long delay, but it will be better to wait it (almost for sure that exec will be visible by swarm) than give workspace starting error to user)
There was a problem hiding this comment.
I think it is not so critical because we still trying to figure out proper fix on Swarm side. But I set it to 3 seconds. Hopefully it will be enough.
skabashnyuk
approved these changes
Mar 30, 2017
mmorhun
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Workaround docker exec not found problem in swarm by waiting extra second and sending request again.
Also Swarm connector tries to log docker exec inspect info.
What issues does this PR fix or reference?
Related to #1734
Changelog
Add workaround for bug in Swarm when exec can't be found by Swarm
Release Notes
Docs PR