Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept of Minimal and Full assembly #2060

Merged
merged 19 commits into from
Apr 14, 2017
Merged

Concept of Minimal and Full assembly #2060

merged 19 commits into from
Apr 14, 2017

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Apr 7, 2017

What does this PR do?

The main goal of this issue is to introduce two maven modules for ws-agent minimum set of components that need to start workspace agent. codenvy-ide-core is core ide part, codenvy-wsagent-core is core server side part of workspace agent.

How to use them
We will use them in two ways:

  • As a fundament of our full assembly.
  • As a fundament for our samples.

Full assembly of IDE
To make Full assembly of ide we need to declare in assembly/compiling-ide-war/pom.xml

  1. IDE Core
        <dependency>
            <groupId>org.eclipse.che.core</groupId>
            <artifactId>che-ide-core</artifactId>
        </dependency>
  1. All IDE plugins we have in Codenvy.
        <dependency>
            <groupId>com.codenvy.plugin</groupId>
            <artifactId>codenvy-plugin-*</artifactId>
        </dependency>
  1. All IDE plugins we have in Che.
    <dependency>
            <groupId>org.eclipse.che</groupId>
            <artifactId>assembly-ide-war</artifactId>
            <classifier>classes</classifier>
            <exclusions>
                <exclusion>
                    <artifactId>che-plugin-product-info</artifactId>
                    <groupId>org.eclipse.che.plugin</groupId>
                </exclusion>
            </exclusions>
        </dependency>

Custom assembly of IDE based on minimal Codenvy IDE
To make Custom assembly of IDE based on minimal Codenvy IDE* we need to declare in assembly/assembly-ide-war/pom.xml

  1. Codenvy IDE Core
        <dependency>
            <groupId>com.codenvy.onpremises</groupId>
            <artifactId>codenvy-ide-core</artifactId>
            <scope>provided</scope>
        </dependency>
  1. IDE part of custom plugin.
        <dependency>
            <groupId>my.plugin</groupId>
            <artifactId>plugin-json-ide</artifactId>
            <scope>provided</scope>
        </dependency>
  1. IDE war that will be reused to get some resources
        <dependency>
            <groupId>com.codenvy.onpremises</groupId>
            <artifactId>assembly-ide-war</artifactId>
            <type>war</type>
            <scope>runtime</scope>
        </dependency>

Full assembly of Ws-agent server war

  1. Core Ws agent war
        <dependency>
            <groupId>com.codenvy.onpremises.wsagent</groupId>
            <artifactId>codenvy-wsagent-core</artifactId>
            <type>war</type>
        </dependency>
  1. Swagger support
        <dependency>
            <groupId>org.eclipse.che.lib</groupId>
            <artifactId>che-swagger-module</artifactId>
        </dependency>

3.All Codenvy ws-agent plugins

        <dependency>
            <groupId>com.codenvy.plugin</groupId>
            <artifactId>codenvy-plugin-*</artifactId>
        </dependency>

4.All Che ws-agent plugins

   <dependency>
            <groupId>org.eclipse.che</groupId>
            <artifactId>assembly-wsagent-war</artifactId>
            <classifier>classes</classifier>
            <exclusions>
                <exclusion>
                    <artifactId>che-wsagent-core</artifactId>
                    <groupId>org.eclipse.che.core</groupId>
                </exclusion>
            </exclusions>
        </dependency>

Custom assembly of ws-agent base minimal Codenvy ws-agent

  1. Core Ws agent war
        <dependency>
            <groupId>com.codenvy.onpremises.wsagent</groupId>
            <artifactId>codenvy-wsagent-core</artifactId>
            <type>war</type>
        </dependency>
  1. Plugin server side
        <dependency>
            <groupId>my.plugin</groupId>
            <artifactId>plugin-json-server</artifactId>
        </dependency>

What issues does this PR fix or reference?

eclipse-che/che#4403
eclipse-che/che#4578

Changelog

Introduced two maven modules for ws-agent minimum set of components that need to start workspace agent

Release Notes

Docs PR

eclipse-che/che-docs#202

@benoitf
Copy link
Contributor

benoitf commented Apr 7, 2017

it seems branch requires rebase updates (or it will be a squash merge ?)

@bmicklea bmicklea changed the title [WP] Concept of Basic and Full assembly [WP] Concept of Minimal and Full assembly Apr 7, 2017
@skabashnyuk skabashnyuk changed the title [WP] Concept of Minimal and Full assembly Concept of Minimal and Full assembly Apr 8, 2017
@riuvshin riuvshin modified the milestones: 5.8.0, 5.9.0 Apr 11, 2017
@skabashnyuk
Copy link
Contributor Author

@bmicklea @JamesDrummond after this pr eclipse-che/che-archetypes#44 plugin-json-archetype will be based on minimal assembly.

@skabashnyuk skabashnyuk merged commit 5f62567 into master Apr 14, 2017
@skabashnyuk skabashnyuk deleted the che4403 branch April 14, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants