-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept of Minimal and Full assembly #2060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
requested review from
benoitf,
vparfonov,
riuvshin,
slemeur,
tolusha,
bmicklea and
JamesDrummond
April 7, 2017 12:14
it seems branch requires rebase updates (or it will be a squash merge ?) |
benoitf
approved these changes
Apr 7, 2017
vparfonov
approved these changes
Apr 7, 2017
bmicklea
changed the title
[WP] Concept of Basic and Full assembly
[WP] Concept of Minimal and Full assembly
Apr 7, 2017
skabashnyuk
changed the title
[WP] Concept of Minimal and Full assembly
Concept of Minimal and Full assembly
Apr 8, 2017
tolusha
approved these changes
Apr 10, 2017
riuvshin
approved these changes
Apr 10, 2017
@bmicklea @JamesDrummond after this pr eclipse-che/che-archetypes#44 plugin-json-archetype will be based on minimal assembly. |
bmicklea
approved these changes
Apr 13, 2017
JamesDrummond
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The main goal of this issue is to introduce two maven modules for ws-agent minimum set of components that need to start workspace agent.
codenvy-ide-core
is core ide part,codenvy-wsagent-core
is core server side part of workspace agent.How to use them
We will use them in two ways:
Full assembly of IDE
To make Full assembly of ide we need to declare in assembly/compiling-ide-war/pom.xml
Custom assembly of IDE based on minimal Codenvy IDE
To make Custom assembly of IDE based on minimal Codenvy IDE* we need to declare in assembly/assembly-ide-war/pom.xml
Full assembly of Ws-agent server war
3.All Codenvy ws-agent plugins
4.All Che ws-agent plugins
Custom assembly of ws-agent base minimal Codenvy ws-agent
What issues does this PR fix or reference?
eclipse-che/che#4403
eclipse-che/che#4578
Changelog
Introduced two maven modules for ws-agent minimum set of components that need to start workspace agent
Release Notes
Docs PR
eclipse-che/che-docs#202