Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODENVY-994 Show the user nickname in the left bottom corner of UD #2163

Merged
merged 1 commit into from
May 5, 2017

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented May 5, 2017

Signed-off-by: Oleksii Orel oorel@codenvy.com

What does this PR do?

Show the user email as user nickname in the left bottom corner of UD NavBar in the case when user first name and user last name are empty.

What issues does this PR fix or reference?

#994

Changelog

-- Show the user email in the case when user first name and user last name are empty.

Release Notes

N/A

selection_021
selection_022

* Returns user nickname.
* @return {string}
*/
getUserNickname(): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename it to getUserName()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or getUserDisplayName

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK
done

@ashumilova ashumilova added this to the 5.10.0 milestone May 5, 2017
…username is empty

Signed-off-by: Oleksii Orel <oorel@codenvy.com>
@olexii4 olexii4 merged commit 9673f10 into master May 5, 2017
@olexii4 olexii4 deleted the CODENVY-994 branch May 5, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants