CODENVY-1812 Add ability to use -1 in the amount of resources #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olexii4
approved these changes
May 11, 2017
benoitf
reviewed
May 11, 2017
| @@ -105,7 +105,7 @@ export class RamInfoController { | |||
| let ram = this.lodash.find(resources, (resource: any) => { | |||
| return resource.type === CodenvyResourceLimits.RAM; | |||
| }); | |||
| return ram ? (ram.amount / 1024) : 0; | |||
| return (ram && ram.amount > -1) ? (ram.amount / 1024) : -1; | |||
There was a problem hiding this comment.
should it be instead of > -1 or > 0 (or != -1)
akurinnoy
approved these changes
May 11, 2017
skabashnyuk
approved these changes
May 11, 2017
akorneta
approved these changes
May 11, 2017
benoitf
approved these changes
May 11, 2017
Signed-off-by: Ann Shumilova <ashumilova@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ability to use -1 in the amount of resources while setting resources limits via external configurations or via free resources service.
What issues does this PR fix or reference?
#1812
Changelog
Added ability to use -1 in the amount of resources.
Release Notes
N/A
Docs PR
N/A