CODENVY-2164: Add search user method by email/username for admins #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorneta
requested review from
slemeur,
tolusha,
voievodin,
mkuznyetsov and
sleshchenko
mkuznyetsov
approved these changes
May 15, 2017
tolusha
reviewed
May 15, 2017
| @ApiResponses({@ApiResponse(code = 200, message = "The response contains searching result"), | ||
| @ApiResponse(code = 400, message = "Missed required parameters, parameters are not valid"), | ||
| @ApiResponse(code = 500, message = "Internal server error occurred")}) | ||
| public Response find(@ApiParam("User e-mail fragment") |
There was a problem hiding this comment.
Usually searching criteria tends to extend. It is better to pass DTO to avoid method signature refactoring in the future.
There was a problem hiding this comment.
I guess that in this case it is not critical, because user does not provide to many fields to search by, but for me it's ok to use DTO class instead of query parameters
|
Why |
|
added changes log |
tolusha
approved these changes
May 15, 2017
voievodin
approved these changes
May 15, 2017
sleshchenko
approved these changes
May 15, 2017
|
Is this API documented in swagger? |
|
@slemeur yes |
akorneta
force-pushed
the
CODENVY-2164
branch
2 times, most recently
from
36f92fd
to
72b135c
Compare
slemeur
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides a method for administrators that allow to search users by email/name parts. New method is case insensitive and finds users with names/emails that contains given part.
method path:
api.endpoint/admin/user/findWhat issues does this PR fix or reference?
#2164
Changelog
Add search user method by email/username for admins
Release Notes
Add new API to allow system admin to search users by names and emails