Add possibility to extend codenvy.env with addon.env if it exist #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this improve allows to have
addon.envfile and inject values fromaddon.envtocodenvy.envin custom CLI based on CODENVY CLI. As result user will have codenvy.env with ENV vars from addon.This merge happens ONLY on first init where codenvy.env not yet generated, to prevent any collisions.
example of usage in saas assembly: https://github.com/codenvy/saas/pull/224
What issues does this PR fix or reference?
eclipse-che/che#5117
Changelog
Add possibility to extend codenvy.env with addon.env if it exist