Provide ability to manage public stacks for codenvy admins #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
reviewed
Jun 1, 2017
| @@ -507,5 +505,7 @@ protected void configure() { | |||
| bind(org.eclipse.che.api.agent.server.filters.AddExecAgentInStackFilter.class); | |||
|
|
|||
| bind(org.eclipse.che.api.workspace.server.event.WorkspaceJsonRpcMessenger.class).asEagerSingleton(); | |||
|
|
|||
| bind(DomainsPermissionsCheckers.class); | |||
There was a problem hiding this comment.
This binding is redundant.
skabashnyuk
reviewed
Jun 1, 2017
|
|
||
| /** | ||
| * @author Anton Korneta | ||
| */ |
| * @author Anton Korneta | ||
| */ | ||
| @Singleton | ||
| public class StackDomainSetPermissionsChecker implements SetPermissionsChecker { |
| </goals> | ||
| <configuration> | ||
| <target> | ||
| <unzip dest="${project.build.directory}/stacks/" src="${org.eclipse.che.core:che-core-ide-stacks:jar}" /> |
sleshchenko
force-pushed
the
stacks_recipes_loading_policy
branch
from
d637f2c
to
8819c59
Compare
akorneta
force-pushed
the
stacks_recipes_loading_policy
branch
2 times, most recently
from
f5d8ae1
to
3571119
Compare
sleshchenko
reviewed
Jun 7, 2017
| } | ||
| permissionsDao.store(new RecipePermissionsImpl("*", recipe.getId(), singletonList("search"))); | ||
| } catch (ServerException | ConflictException ex) { | ||
| LOG.error("Failed to store recipe {} ", recipe.getId(), ex.getMessage()); |
There was a problem hiding this comment.
two extra arguments but one {} in the message
akorneta
force-pushed
the
stacks_recipes_loading_policy
branch
from
9d4e264
to
00085c8
Compare
sleshchenko
approved these changes
Jun 8, 2017
akorneta
force-pushed
the
stacks_recipes_loading_policy
branch
2 times, most recently
from
ebee849
to
ac87b84
Compare
|
For the same reasons than on eclipse-che/che#5234 . I'm -1 with the update policy here as well. |
akorneta
force-pushed
the
stacks_recipes_loading_policy
branch
3 times, most recently
from
307c31f
to
3baddfd
Compare
|
Updated doc + added property |
akorneta
force-pushed
the
stacks_recipes_loading_policy
branch
from
3baddfd
to
bc010bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rewrite public stacks and recipes loading in accordance with che.
Provides a mechanism for extending the default permission filter logic on the domain-level for permission service.
Moves
stacks.jsoninto resource instead of configuration folder.What issues does this PR fix or reference?
#2208
Changelog
Updated default stack loading policy, provides ability to add/delete predefined stacks for admins using stack API.
Release Notes
Default stacks loading policy was changed, now stacks loaded once on database initialization.
Those who use previous(load per server start) strategy may continue using it by setting
CODENVY_PREDEFINED_STACKS_RELOAD_ON_STARTproperty value totrue.Added ability to add/delete predefined stacks for admin user through stack API.