CODENVY-2350: Remove system license #2359
Conversation
|
There are definitely docs changes needed to the scaling section at least (possibly more). |
There was a problem hiding this comment.
There is connected code, which should be cleaned up as well:
- in site module: https://github.com/codenvy/codenvy/blob/CODENVY-2350_ENT/site/app/site/auth/accept-fair-source-license.html ...
- in dashboard: https://github.com/codenvy/codenvy/blob/CODENVY-2350_ENT/dashboard/src/app/admin/onprem-administration/license/license.html ...
- in saas project: https://github.com/codenvy/saas/blob/master/saas-site/app/site/scripts/app.js#L73 ...
- in selexica: https://github.com/codenvy/silexica/blob/master/site/app/site/error/fair-source-license-is-not-accepted-error.html ...
More info about license related changes in Codenvy could be found here.
|
|
||
| printDelimiter(auditReport, "CURRENT STATE"); | ||
|
|
||
| printSystemInfo(auditReport); |
There was a problem hiding this comment.
System Info includes info about number of users, and this info could be useful for someone.
@bmicklea: could you, please, confirm if audit report should still include such info:
Number of users: {allUsersNumber}
|
@dmytro-ndp |
|
It may be out of scope for this issue but is part of the business requirement. |
It depends on onpremises-assembly-parent, so it definitely ends up with broken login, IMHO |
This changes along will definitely break up first login through site, and caused error messages in dashboard AFAIK. Did you test it? |
|
@tolusha: I propose to make all required changes for license removal, including changes in dashboard and site, within one branch and then merge all of them at once. |
|
Ok .I don't mind. |
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
|
It starts now and works well |
|
@bmicklea |
|
Any way I restored printing the total number of users. |
|
@tolusha, yes you are right - tracking total users is best even if we don't have a license it helps with capacity planning. |
|
Good job! |
What does this PR do?
Removes all system license checks. It means no more users limitation number.
What issues does this PR fix or reference?
#2350
Changelog
Removes users limitation number.
Release Notes
Removes users limitation number.
Docs PR
codenvy/docs#131