Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping of selenium tests #2534

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Housekeeping of selenium tests #2534

merged 2 commits into from
Nov 17, 2017

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Nov 17, 2017 •
edited

What does this PR do?

  • Removes deprecated ide.driver() method from selenium tests.
  • Fixes static code analyzer warnings in selenium tests.
  • Remove useless page objects from the com.codenvy.selenium.pageobject.dashboard.organization package which had been copied into the Eclipse Che repository before.

What issues does this PR fix or reference?

eclipse-che/che#6118

Dmytro Nochevnov added 2 commits November 15, 2017 16:57
Remove deprecated ide.driver() from selenium tests
12533c6 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
Fix static code analyzer warnings in selenium tests
eab5498 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
@dmytro-ndp dmytro-ndp merged commit 869eb13 into master Nov 17, 2017
@dmytro-ndp dmytro-ndp deleted the che-6118 branch November 17, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk skabashnyuk is a code owner

Assignees
No one assigned
Labels
kind/task team/production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmytro-ndp @tolusha