che-1518: Fix creation zombie prosess when user closes terminal. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@garagatyi @evoevodin up to you to decide should we merge this pr or not |
|
We are going to make the release for early next week non-shippable. It will only be for internal testing - so we will make the following release (4.8) a shippable release. So slipping is ok - it's going to be in next customer shipment regardless. |
|
@AndrienkoAleksandr is this something that is going to be merged this week? |
|
@vkuznyetsov Please review. |
Fix creation zombie processes when user closes terminal by close button or prints command exit in the terminal. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
che-1518
branch
from
bd06bc0
to
052451b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
eclipse-che/che#1518
Previous Behavior
After click close button user will see in the list of processes terminal (/bin/bash) zombie process
Tests written?
No
Docs requirements?
Include the content for all the docs changes required.