Add pvc example #26
Merged
Add pvc example #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate Cute components to SYCL
* Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
* Update README-sycl.md Fixing CUDA version
taozha2
requested review from
rolandschulz,
Jiaxingla and
mehdi-goli
and removed request for
Jiaxingla
jiyang1011
approved these changes
Apr 16, 2024
tdeng5
approved these changes
Apr 16, 2024
Jiaxingla
approved these changes
Apr 16, 2024
mehdi-goli
reviewed
Apr 16, 2024
mehdi-goli
reviewed
Apr 16, 2024
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
mehdi-goli
reviewed
Apr 16, 2024
mehdi-goli
reviewed
Apr 16, 2024
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
Merged
|
What's the point of the intel_gpu_backend_enabling branch? It is just behind sycl-develop. Why would we want two different branches? Note that #24 was already open. Containing the same code and trying to merge it into sycl-develop. Also we should try to avoid reviewing code which isn't actual part of this PR. All Mehdi's comments are for code part of #23 and already addressed there. If we create PRs depending on other PRs we should put that in the description so that people know to only review the last commit(s). |
we use this branch for intel gpu backend related experiments and avoid be interrupted/interrupting sycl-develop branch, will merge our features back to master when the feature is mature enough. |
rolandschulz
approved these changes
Apr 17, 2024
jiyang1011
pushed a commit
to jiyang1011/cutlass-fork
that referenced
this pull request
Apr 24, 2024
…playsoftware#29) * Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * fixing device only code that get called in the host side (codeplaysoftware#25) * Fix GPU clock (codeplaysoftware#21) * Apply suggestions from code review Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Fix typo in Macro (codeplaysoftware#28) Fix typo in Macro Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Cosmetic --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Applying the comments --------- Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com> * Revert "Updating README-sycl.md to capture the 3.5 modifications (codeplaysoftware#16)" (codeplaysoftware#17) This reverts commit a726bd3. * fix typo in macro --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com> --------- Co-authored-by: Atharva Dubey <atharva.dubey@codeplay.com> Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com> Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> Add pvc example (codeplaysoftware#26) * Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * Add example * Update include/cute/util/sycl_vec.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/atom/mma_traits_xe.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/atom/mma_atom.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/arch/mma_xe.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> --------- Co-authored-by: Atharva Dubey <atharva.dubey@codeplay.com> Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com> Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> Co-authored-by: Roland Schulz <roland.schulz@intel.com> add prefetch, mkl validation, and group partition misc refine Make atom type a make_2d_copy argument Use cute::bfloat16_t add KK=2 enable btile prefetch, got 250Tflops (codeplaysoftware#4) direct big tile, got 280Tflops remove unused code and add more print (codeplaysoftware#7) enable unaligned shape like 4098 (codeplaysoftware#9) add barrier and wait enable big tile modify some datatype
jiyang1011
pushed a commit
to jiyang1011/cutlass-fork
that referenced
this pull request
Apr 29, 2024
* Migrate cute components to SYCL (codeplaysoftware#19) * Migrate Cute components to SYCL * Add CMake configuration (codeplaysoftware#20) * Add cmake configuration * Update examples/cute/tutorial/CMakeLists.txt Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> --------- Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update README-sycl.md (codeplaysoftware#22) * Update README-sycl.md Fixing CUDA version * Add XE MMA/copy atom * Update to 3.5 API * Add example * Update include/cute/util/sycl_vec.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/atom/mma_traits_xe.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/atom/mma_atom.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> * Update include/cute/arch/mma_xe.hpp Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> --------- Co-authored-by: Atharva Dubey <atharva.dubey@codeplay.com> Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com> Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com> Co-authored-by: Roland Schulz <roland.schulz@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.