core: ui refactor #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nibilin33
commented
Nov 21, 2022
nibilin33
commented
- top toolbar
- editor hightlight
- implement delete btn
1. top toolbar 2. editor hightlight 3. implement delete btn
lihebi
reviewed
Nov 21, 2022
lihebi
reviewed
Nov 21, 2022
|
One more thing: the syntax highlights of Monaco editor seems to be gone. This is what it looked like before: |
lihebi
reviewed
Nov 21, 2022
custom theme, i wanna remove the active input border; now, i just add some simple rule, i will find full rule to extend later. |
lihebi
reviewed
Nov 21, 2022
ui/src/components/MyMonaco.tsx
Outdated
| @@ -6,6 +6,24 @@ import { useStore } from "zustand"; | |||
| import { RepoContext } from "../lib/store"; | |||
| import { MonacoBinding } from "y-monaco"; | |||
|
|
|||
| const theme: monaco.editor.IStandaloneThemeData = { | |||
| base: "vs", | |||
| inherit: false, | |||
There was a problem hiding this comment.
You can just set this to true.
ui/src/components/MyMonaco.tsx
Outdated
Comment on lines
13
to
19
| { | ||
| token:'keyword', | ||
| foreground: "#4b83cd" | ||
| },{ | ||
| token: 'comment', | ||
| foreground: '#aaaaaa' | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.