Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document libcxx requirement #1706

Closed
pwwang opened this issue May 21, 2020 · 3 comments
Closed

Document libcxx requirement #1706

pwwang opened this issue May 21, 2020 · 3 comments
Assignees
Labels
docs Documentation related
Milestone

Comments

@pwwang
Copy link

pwwang commented May 21, 2020

I only have 2.17 on RedHatEnterpriseServer 7.7, which runs code-server 3.2.0 perfectly.

However, it started to crash after the upgrade (to 3.3.0 and 3.3.1). Is it because of vscode upgrade or code-server that leverages the minimal version of glibc?

Below is the crash log:

Error: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /path/to/code-server-3.3.1-linux-x86_64/lib/vscode/node_modules/spdlog/build/Release/spdlog.node)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1250:18)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at Module.patchedRequire [as require] (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/node_modules/diagnostic-channel/dist/src/patchRequire.js:14:46)
    at require (internal/modules/cjs/helpers.js:73:18)
    at bindings (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/node_modules/spdlog/node_modules/bindings/bindings.js:112:48)
    at Object.<anonymous> (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/node_modules/spdlog/index.js:3:35)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at Module.patchedRequire [as require] (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/node_modules/diagnostic-channel/dist/src/patchRequire.js:14:46)
    at require (internal/modules/cjs/helpers.js:73:18)
    at t.load (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:16:119)
    at e.load (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:13:586)
    at i (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:29:259)
    at Object.errorback (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:29:383)
    at e.triggerErrorback (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:13:955)
    at /path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:13:659
    at ReadFileContext.callback (/path/to/code-server-3.3.1-linux-x86_64/lib/vscode/out/vs/loader.js:16:494)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:260:13) {
  phase: 'loading',
  moduleId: 'spdlog',
  neededBy: [ '===anonymous3===' ]
}

BTW, I don't have privileges to upgrade glibc on the server.

@nhooyr
Copy link
Contributor

nhooyr commented May 21, 2020

Sorry about this, I forgot to document libcxx requirement. libc is different from libcxx.

I'll be sure to document this. In the meantime you can use the npm package. See the instructions in the README.

@nhooyr nhooyr self-assigned this May 21, 2020
@nhooyr nhooyr added the docs Documentation related label May 21, 2020
@nhooyr nhooyr changed the title Do we really need glibc 2.19+? Document libcxx requirement May 21, 2020
@nhooyr
Copy link
Contributor

nhooyr commented May 21, 2020

Good news we're gonna make it static in regards to libstdcxx!

So next release won't even depend on it and only depend on libc.

@pwwang
Copy link
Author

pwwang commented May 21, 2020

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

No branches or pull requests

2 participants