Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): ignore lib/vscode #5347

Merged
merged 1 commit into from
Jul 15, 2022
Merged

chore(prettier): ignore lib/vscode #5347

merged 1 commit into from
Jul 15, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 15, 2022

We were using an overrides command in our .prettierrc.yaml which
quickly became out of sync with Code's Prettier styles.

Instead, we simply tell Prettier to ignore lib/vscode.

This way, if you have formatOnSave on and you save inside
lib/vscode, you won't convert the file to use code-server's styles.

Fixes #

We were using an overrides command in our `.prettierrc.yaml` which
quickly became out of sync with Code's Prettier styles.

Instead, we simply tell Prettier to ignore `lib/vscode`.

This way, if you have `formatOnSave` on and you save inside
`lib/vscode`, you won't convert the file to use code-server's styles.
@jsjoeio jsjoeio requested a review from a team July 15, 2022 20:49
@jsjoeio jsjoeio self-assigned this Jul 15, 2022
@github-actions
Copy link

✨ code-server docs for PR #5347 is ready! It will be updated on every commit.

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Jul 15, 2022
@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 15, 2022
@jsjoeio jsjoeio enabled auto-merge (squash) July 15, 2022 20:49
@jsjoeio jsjoeio temporarily deployed to npm July 15, 2022 20:53 Inactive
@github-actions
Copy link

✨ code-server dev build published to npm for PR #5347!

  • Last publish status: success
  • Commit: 1f31d3a

To install in a local project, run:

npm install @coder/code-server-pr@5347

To install globally, run:

npm install -g @coder/code-server-pr@5347

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #5347 (1f31d3a) into main (907dd83) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5347   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      367      367           
=======================================
  Hits         1211     1211           
  Misses        399      399           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907dd83...1f31d3a. Read the comment docs.

@jsjoeio jsjoeio merged commit 19f486b into main Jul 15, 2022
@jsjoeio jsjoeio deleted the jsjoeio/prettier branch July 15, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants