Enable secret storage

[code-asher]

It seems that at some point the secret storage went browser-only, but the browser only persists storage if it gets a key from the server to do encryption. So this implements that endpoint. Normally the process is kicked off by the presence of a cookie that contains the endpoint but I patched the endpoint in directly because making cookies work with a base path is a bit annoying since they cannot be relative (for the login cookie we send the full path from the client to the server to account for that).

Additionally, I tested --github-auth and it works without our patch so I removed it.

Fixes #6408
Fixes #5072
Fixes #6395

[codecov]

Codecov Report

Merging #6450 (55f8bab) into main (5428442) will decrease coverage by 0.57%.
Report is 2 commits behind head on main.
The diff coverage is 20.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6450      +/-   ##
==========================================
- Coverage   73.70%   73.13%   -0.57%     
==========================================
  Files          31       31              
  Lines        1886     1906      +20     
  Branches      407      409       +2     
==========================================
+ Hits         1390     1394       +4     
- Misses        419      433      +14     
- Partials       77       79       +2     

Files	Coverage Δ
src/node/routes/vscode.ts	33.33% <20.00%> (-3.38%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468cf5c...55f8bab. Read the comment docs.

[benz0li]

@code-asher Thank you for investigating. This is great news.

Could you please release v4.17.1 incorporating this change?

Thank you.

[code-asher]

Definitely will, there is one extension that still seems to be having trouble authenticating so I am trying to figure that out, but once I do I will put out a patch release.

[code-asher]

Actually I need to test the build changes for arm anyway so I am going to make an RC for now to do that.