fix: Insert provisioner job logs async (#185)

The context could be cancelled after a log is sent, which resulted in a failure. This prevent's that from occurring by using the background context.
coder · Feb 7, 2022 · 13360e2 · 13360e2
1 parent d55231c
commit 13360e2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/coderd/provisionerdaemons.go b/coderd/provisionerdaemons.go
@@ -305,9 +305,8 @@ func (server *provisionerdServer) UpdateJob(stream proto.DRPCProvisionerDaemon_U
 			insertParams.Source = append(insertParams.Source, logSource)
 			insertParams.Output = append(insertParams.Output, log.Output)
 		}
-		logs, err := server.Database.InsertProvisionerJobLogs(stream.Context(), insertParams)
+		logs, err := server.Database.InsertProvisionerJobLogs(context.Background(), insertParams)
 		if err != nil {
-			server.Logger.Error(stream.Context(), "insert provisioner job logs", slog.Error(err))
 			return xerrors.Errorf("insert job logs: %w", err)
 		}
 		data, err := json.Marshal(logs)

diff --git a/database/dump.sql b/database/dump.sql
diff --git a/database/models.go b/database/models.go