Skip to content

Commit

Permalink
fix: Remove action from build cancelation names (#4930)
Browse files Browse the repository at this point in the history
This looked weird in the UI and didn't conform to our other states.
  • Loading branch information
kylecarbs committed Nov 8, 2022
1 parent 2789fb7 commit b970438
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions codersdk/workspacedisplaystatus.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ func WorkspaceDisplayStatus(jobStatus ProvisionerJobStatus, transition Workspace
case ProvisionerJobPending:
return "Queued"
case ProvisionerJobCanceling:
return "Canceling action"
return "Canceling"
case ProvisionerJobCanceled:
return "Canceled action"
return "Canceled"
case ProvisionerJobFailed:
return "Failed"
default:
Expand Down
4 changes: 2 additions & 2 deletions codersdk/workspacedisplaystatus_internal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ func TestWorkspaceDisplayStatus(t *testing.T) {
name: "CancelingStatusWithStartTransition",
jobStatus: ProvisionerJobCanceling,
transition: WorkspaceTransitionStart,
want: "Canceling action",
want: "Canceling",
},
{
name: "CanceledStatusWithStartTransition",
jobStatus: ProvisionerJobCanceled,
transition: WorkspaceTransitionStart,
want: "Canceled action",
want: "Canceled",
},
{
name: "FailedStatusWithDeleteTransition",
Expand Down

0 comments on commit b970438

Please sign in to comment.