-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Sharable ports #11486
Comments
adding this issue: #12232 |
#12232 will be a requirement for this to make GA. |
@kylecarbs the feature allows admins to restrict the maximum sharing level of ports in the template settings. If you're on our dev template the maximum sharing level is We could add a tooltip if this is unclear. |
Yup I was thinking a tooltip will fix that nicely |
Instead of the tooltip, we can also remove it from the dropdown if not allowed at the template level. |
Added #12832 since these are intertwined from a UX perspective. |
@bpmct the list is complete. Added docs and GA issues. |
@stirby What do you mean by "If you're on our dev template"? I'm on an OSS deployment, upgraded from v2.10.2 to v2.11.0 today, and am seeing the same thing as @kylecarbs: "public" option is greyed out. In the workspace settings, the "Public" option is pre-selected and unmodifiable, as expected. The documentation on port forwarding says:
I can't seem to find a way to enable public port sharing via the port helper. |
@coder/ts @coder/pms some good feedback here ⬆️ |
@matifali do you think we should open a ticket for redesigning this UI? I think having a ticket can give us time to try different alternatives and solutions based on user feedback and the opportunity to think about it more deeply. |
@matifali @BrunoQuaresma We considered a design quite similar to this is one in the past and I like the consolidation. I'd like to review the mockups before we make a decision. |
@stirby Sure, I think the first decision we have to make is if we want to spend some time working on the design before jumping into a fix/improvement. If yes, which I think we all agree, the person who creates the designs can share them with the team, including you and other PMs, to collect feedback and get approval. Wdyt? |
Sounds good, moved to new issue. |
Awesome! Looking forward to it. @stirby could you please elaborate on #11486 (comment) ? The observed behavior doesn't currently match what's stated in the docs... |
Hey @pauliuspetk I can look into this behavior and get back to you, I think I understand from your description but want to investigate and see what is going on here to create this mismatch. Thanks for bringing this up. |
@stirby a question about releases. When a feature is made GA in a release, which has a bug that is later fixed in For example, #13259 fixes the port sharing level, which was made GA in v2.11.0, but it still needs to be released as a patch. |
Ran into that bug as well. |
Problem
Customers want to be able to expose arbitrary ports to other users at different levels of permissions for how those ports can be shared. 2-3 major customers are already making workarounds for this missing feature, so we should build something first class to fit this need.
RFC
https://www.notion.so/coderhq/Shareable-Ports-4140e809958c457ba99f53b3e9ae1673?pvs=4
Related
Port is missing when port-forwarding via Dashboard #8189:: This is a coder config issueports
workspace UI when running Jupyter #10266Action Items
Required
shared_ports
enterprise feature key #11845Internal server scheme
setting for port sharing #12232Reach
The text was updated successfully, but these errors were encountered: