Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspace timeline rows obviously clickable #2021

Closed
Tracked by #1939
ketang opened this issue Jun 3, 2022 · 7 comments · Fixed by #2047
Closed
Tracked by #1939

Make workspace timeline rows obviously clickable #2021

ketang opened this issue Jun 3, 2022 · 7 comments · Fixed by #2047
Assignees
Labels
feature Something we don't have yet site Area: frontend dashboard
Milestone

Comments

@ketang
Copy link
Contributor

ketang commented Jun 3, 2022

What is your suggestion?

It is not obvious that these rows are clickable
Screen Shot 2022-06-03 at 16 29 12

Why do you want this feature?

So users understand they can get more information about a workspace.

Are there any workarounds to get this functionality today?

n/a

Are you interested in submitting a PR for this?

no

@ketang ketang added feature Something we don't have yet needs grooming 🪒 labels Jun 3, 2022
@BrunoQuaresma
Copy link
Collaborator

I think for this, we could add a "chevron right" at the end of each log row. It is a very common pattern on MUI.
Screen Shot 2022-06-03 at 11 58 51

@ketang
Copy link
Contributor Author

ketang commented Jun 3, 2022

Perfect

@BrunoQuaresma
Copy link
Collaborator

For who is going to take this ticket:

  • The icon is ChevronRight from MUI
  • We can change the hover color of the row to match the hover color from the nav item to make it consistent

@AbhineetJain AbhineetJain self-assigned this Jun 3, 2022
@ammario ammario added this to the Community MVP milestone Jun 3, 2022
@misskniss misskniss changed the title Feat: make workspace timeline rows obviously clickable Make workspace timeline rows obviously clickable Jun 3, 2022
@f0ssel
Copy link
Contributor

f0ssel commented Jun 3, 2022

Chatted with @BrunoQuaresma , we think these improvements should also be made to the templates page for the same reasons!

@AbhineetJain
Copy link
Contributor

@f0ssel Thank you for the update! I'll take care of both in the same PR then!

@AbhineetJain
Copy link
Contributor

Screen Shot 2022-06-03 at 4 12 33 PM

@f0ssel @BrunoQuaresma Just wanted to confirm if this was the table we wanted to add the icon to. We already have an anchor link with the template name here. Should we still keep that? Or just make the row clickable to go to that link? Additionally should we do the same on the Workspaces list page?

@misskniss misskniss added the site Area: frontend dashboard label Jun 7, 2022
@f0ssel
Copy link
Contributor

f0ssel commented Jun 7, 2022

@AbhineetJain sorry I missed this. I am not the end all be all but my opinion would be:

  • Only change the "Templates" page
  • Add the hover and the arrow
  • Maybe remove the link on the template name in favor of the entire row - however this is done on the timeline rows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something we don't have yet site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants