feat: Make workspace timeline rows obviously clickable #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The grey background looks like it's hovered and not clickable. I think the Chevron-only is better. |
The grey background is only when it is hovered. The screenshot is from when the row is hovered upon. |
|
Doesn't have to be this PR, but could we get this treatment on the templates page? @kylecarbs and I just talked about this improvement and think it would help with pushing users to an action on the templates page. |
AbhineetJain
force-pushed
the
abhineetjain/2021-make-rows-obviously-clickable
branch
from
7d9db12
to
d29238b
Compare
AbhineetJain
force-pushed
the
abhineetjain/2021-make-rows-obviously-clickable
branch
from
c553981
to
5834755
Compare
|
@presleyp @BrunoQuaresma Can you help with approving the updated UI tests? If you believe I can do that myself, that also works. |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
…2047) * add right arrow to build table rows * Add clickable rows to template and workspace list * Specify 1% width for chevron right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make workspace timeline rows obviously clickable.
Subtasks
Fixes #2021
Fixes #2058
Screenshot
Timeline (with hover)
Templates list
Workspaces list